chore: remove abandoned modular-architecture crates and dead contract modules#483
chore: remove abandoned modular-architecture crates and dead contract modules#483RUKAYAT-CODER wants to merge 2 commits into
Conversation
…ktop-teachLink-contract/bb6b2c0c-69b2-43d6-ba37-ba3f90e13957/scratchpad/commit_msg.txt
…ktop-teachLink-contract/bb6b2c0c-69b2-43d6-ba37-ba3f90e13957/scratchpad/fmt_commit_msg.txt
|
Note on CI: the |
Summary
contracts/{insurance,licenses,market,marketplace,tokenization,governance,collaboration}crates. These are leftovers from a reverted modular-architecture experiment (376ae87, reverted in76a8cac): none are Cargo workspace members, none are referenced anywhere, none are documented in CHANGELOG/TRACKING. Some (marketplace,tokenization,market) are written against the ink!/Substrate framework, not Soroban.contracts/market/src/lib.rswas a byte-identical copy ofcontracts/insurance/src/lib.rs.notification_events.rsandnotification_events_simple.rsfromteachlink- superseded drafts;lib.rsonly ever compilednotification_events_basic.teachlinkmodules that were// mod'd out behindTODO: Fix ... compilation errors (pre-existing issue)comments with no tracked plan:collaboration,content_nft,content_quality,fractional,learning_paths,licensing,marketplace,royalty,social_events,social_learning. Checked open issues for each by name - zero matches. Leftevent_tests.rs/validation_tests.rsalone since those are disabled tests for currently-active modules (events,bridge,escrow,validation, etc.), not dead feature code, and leftnotification_tests.rs.disabledalone since TRACKING.md already tracks re-enabling it.pub use types::{...}re-export block inlib.rs, which repeated ~55 of its ~100 identifiers twice within the sameusestatement.testing/{performance,quality,analytics,security}scaffolding - confirmed viatesting/Cargo.toml/testing/src/lib.rsthat none of it is compiled; it duplicates the livescripts/*.sh+regression.ymlgas/perf checks without ever being invoked.check-added-large-filespre-commit hook so build artifacts can't be committed again.No workspace members changed (only
contracts/teachlinkandcontracts/documentationever were), so this shouldn't affect build/test behavior beyond the removed modules no longer existing.Test plan
cargo build --workspacecargo test --workspace --libcargo clippy --workspace --all-features -- -D warningsci.yml,regression.yml) green