Add dashboard keyboard shortcuts - #9878
Open
rohithreddykota wants to merge 1 commit into
Open
Conversation
AdityaHegde
reviewed
Sep 11, 2026
AdityaHegde
left a comment
Collaborator
There was a problem hiding this comment.
Code wise this looks good. The only thing missing is localisation and text is hardcoded in english.
Feature wise, do we need more keyboard shortcuts? Feels wierd to be able to open the filter dropdown for example and arrow keys don't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dashboard-scoped keyboard shortcuts and a discoverable help dialog.
?to show or hide the keyboard-shortcuts menu./,,, or.to open the filter, metric, or dimension picker.Tested with
npm test --workspace web-common -- src/features/dashboards/shortcuts/dashboard-shortcuts.spec.ts(9 tests passing).Checklist: