Skip to content

Add dashboard keyboard shortcuts - #9878

Open
rohithreddykota wants to merge 1 commit into
mainfrom
rohithreddykota/dashboard-keyboard-shortcuts
Open

Add dashboard keyboard shortcuts#9878
rohithreddykota wants to merge 1 commit into
mainfrom
rohithreddykota/dashboard-keyboard-shortcuts

Conversation

@rohithreddykota

@rohithreddykota rohithreddykota commented Sep 10, 2026

Copy link
Copy Markdown
Member

Adds dashboard-scoped keyboard shortcuts and a discoverable help dialog.

  • Press ? to show or hide the keyboard-shortcuts menu.
  • Press /, ,, or . to open the filter, metric, or dimension picker.
  • Lists the existing cell inspection, selection, chart navigation, zoom, and explain shortcuts in the same menu.
  • Ignores shortcut keys while typing, when modifiers are held, or during repeated keydown events.

Tested with npm test --workspace web-common -- src/features/dashboards/shortcuts/dashboard-shortcuts.spec.ts (9 tests passing).

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks good. The only thing missing is localisation and text is hardcoded in english.

Feature wise, do we need more keyboard shortcuts? Feels wierd to be able to open the filter dropdown for example and arrow keys don't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants