Improve AI timeout handling and error messages#9508
Merged
begelundmuller merged 5 commits intoMay 29, 2026
Conversation
pjain1
reviewed
May 28, 2026
| if strings.HasPrefix(fullMethodName, "/rill.admin.v1.AIService") { | ||
| return time.Minute * 2 | ||
| // NOTE: The runtime usually sets a lower timeout through its AILLMTimeoutSeconds config, so this is more of a hard upper bound. | ||
| return time.Minute * 10 |
Member
There was a problem hiding this comment.
llm_timeout_seconds is configurable now through instance config so does this mean setting anything beyond 10 mins is just not useful?
Contributor
Author
There was a problem hiding this comment.
Yes, the 10 mins here will be a hard-cap for when using Rill's AI service (won't apply if you bring your own token). Since generating tokens for 10 mins can already run up quite a bill, I think it's safest not to allow calls longer than this. What do you think?
Member
There was a problem hiding this comment.
This is good, was just thinking to document somewhere that setting llm_timeout_seconds more than 10 minutes won't help so that user is aware.
Contributor
Author
There was a problem hiding this comment.
Agree, just added docs about it
pjain1
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AILLMTimeoutSeconds, which is usually lower)