fix: transient canvas query errors when adding new components#9501
Merged
Conversation
AdityaHegde
approved these changes
May 26, 2026
|
|
||
| const domainValues = getDomainValues(); | ||
| const hasComparison = $timeAndFilterStore.showTimeComparison; | ||
| const waitingForTimeState = |
Collaborator
There was a problem hiding this comment.
Do not need a isFetching check on sources of timeAndFilterStore?
Member
Author
There was a problem hiding this comment.
I think just a check on the timeRange is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes transient error flashes that appeared when adding new components to an empty canvas dashboard.
New chart components could briefly issue aggregation queries before the canvas time state was fully resolved. For temporal charts, this sent
fillMissing: truewithout a concrete time range, causing:error rewriting to metrics query: time range is required for null fillTables/pivots had a similar initialization race where the pivot config could be built before the metrics-view schema was available. This caused measure fields like
total_recordsto be temporarily classified as dimensions, producing errors such as:invalid dimension "total_records": dimension "total_records" not foundChanges
falseChecklist: