Skip to content

Fix pivot table config after browser refresh #9496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goerch wants to merge 1 commit into from
Closed

Fix pivot table config after browser refresh #9496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions web-common/src/features/dashboards/stores/dashboard-stores.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ function syncMeasures(explore: V1ExploreSpec, exploreState: ExploreState) {
exploreState.tdd.expandedMeasureName = undefined;
}

exploreState.pivot.columns = exploreState.pivot.columns.filter((measure) =>
measuresSet.has(measure.id),
);

if (exploreState.allMeasuresVisible) {
// this makes sure that the visible keys is in sync with list of measures
exploreState.visibleMeasures = [...measuresSet];
Expand Down Expand Up @@ -140,16 +136,6 @@ function syncDimensions(explore: V1ExploreSpec, exploreState: ExploreState) {
exploreState.activePage = DashboardState_ActivePage.DEFAULT;
}

exploreState.pivot.rows = exploreState.pivot.rows.filter(
(dimension) =>
dimensionsSet.has(dimension.id) || dimension.type === PivotChipType.Time,
);

exploreState.pivot.columns = exploreState.pivot.columns.filter(
(dimension) =>
dimensionsSet.has(dimension.id) || dimension.type === PivotChipType.Time,
);

if (exploreState.allDimensionsVisible) {
// this makes sure that the visible keys is in sync with list of dimensions
exploreState.visibleDimensions = [...dimensionsSet];
Expand All @@ -161,6 +147,23 @@ function syncDimensions(explore: V1ExploreSpec, exploreState: ExploreState) {
}
}

function syncPivot(explore: V1ExploreSpec, exploreState: ExploreState) {
const measuresSet = new Set(explore.measures ?? []);
const dimensionsSet = new Set(explore.dimensions ?? []);

exploreState.pivot.rows = exploreState.pivot.rows.filter(
(dimension) =>
dimensionsSet.has(dimension.id) ||
dimension.type === PivotChipType.Time,
);
exploreState.pivot.columns = exploreState.pivot.columns.filter(
(column) =>
measuresSet.has(column.id) ||
dimensionsSet.has(column.id) ||
column.type === PivotChipType.Time,
);
}

const metricsViewReducers = {
init(name: string, initState: ExploreState) {
update((state) => {
Expand Down Expand Up @@ -234,6 +237,9 @@ const metricsViewReducers = {

// remove references to non existent dimensions
syncDimensions(explore, exploreState);

// synchronize pivot rows & columns
syncPivot(explore, exploreState);
});
},

Expand Down