support static data range, rollup priorities#9475
Open
pjain1 wants to merge 4 commits into
Open
Conversation
begelundmuller
approved these changes
May 26, 2026
Comment on lines
+193
to
+195
| if timeDim == mv.TimeDimension && mv.DataTimeRange != "" { | ||
| // Use the declared base data_time_range and skip the OLAP probe. | ||
| res, err = e.resolveDeclaredTimestamps(mv.DataTimeRange) |
Contributor
There was a problem hiding this comment.
Any thoughts on using the data_time_range for all time dimensions, not just the default time dimension?
Member
Author
There was a problem hiding this comment.
Good thought but this was primarily to support rollups which are on primary time dimension only as of now. I think it would be too much to support for all secondary time dims unless someone asks for it which would be rare I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
data_time_rangefor rollups and the base metrics view as well to declare coverage statically, and changes the same-grain selection tiebreaker to definition order to express rollup priority.data_time_rangefield on the metrics view and on each rollup. Accepts a rilltime expression (e.g.-1Y to now,-5Y to -1Y,inf). When set, the OLAPmin/maxprobe for that table is skipped and the declared bounds are used for coverage checks.Example
A publisher-only query for last week routes to
rollup_publisher. Adding a domain filter routes torollup_pub_domain. A query 2 years back routes to rollup_monthly_archive. A query going over both windows falls back to the base.Checklist: