Use a separate connection for the 2FA code verification too - #54
Open
Calvin-Zikakis wants to merge 1 commit into
Open
Use a separate connection for the 2FA code verification too#54Calvin-Zikakis wants to merge 1 commit into
Calvin-Zikakis wants to merge 1 commit into
Conversation
This one still goes over the pooled session, so it can land on a connection Apple has already started 503ing, and the HTML body hits the plist parser the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #52. The 2FA code verification request still goes over the shared pooled session, so it can land on a connection Apple has already started 503ing, and the HTML body hits the plist parser the same way.
Only shows up for accounts with two factor auth, which is why it survived #52.
Same treatment: own session, and surface 5xx instead of parsing it.