feat: 'impl Clone' and inner-error access for TracedError#1
Open
BatmanAoD wants to merge 3 commits into
Open
Conversation
This change makes TracedError a two-way door, making it easier to adopt in a larger codebase. This change provides an "escape hatch" to be able to read and extract error stored within a TracedError. Among other things, this will help adoption of TracedError by: * allowing onboarding users to still match against error variants, as might be common in test cases * allowing crate users to bypass missing or unreleased features * allowing for partial migration of a codebase, so that TracedError can be used in one portion, and then the original error extracted at some interface above which TracedError is not yet used or wanted.
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our "local" version of tokio-rs#3556.
Remainder of motivation and solution copied from kalzoo#1
Motivation
This change makes TracedError a two-way door, making it easier to adopt in a larger codebase.
This change provides an "escape hatch" to be able to read and
extract error stored within a TracedError. Among other things,
this will help adoption of TracedError by:
allowing onboarding users to still match against error variants,
as might be common in test cases
allowing crate users to bypass missing or unreleased features
allowing for partial migration of a codebase, so that TracedError
can be used in one portion, and then the original error extracted
at some interface above which TracedError is not yet used or wanted.
Solution
Add
TracedError::get_inner_errorto get a ref, andTracedError::to_inner_errorto unwrap it entirely