Copy trailing comments in SectionData copy constructor - #260
Open
haraldrohan wants to merge 1 commit into
Open
haraldrohan wants to merge 1 commit into
haraldrohan wants to merge 1 commit into
Conversation
The copy constructor copied the leading comments but not the trailing comments, so cloning a SectionData dropped them. Refs rickyah#156 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SectionDatacopy constructor copiesLeadingCommentsbut notTrailingComments, soSectionData.Clone()silently drops them. This is the fix suggested in #156.Adds a test that checks both comment lists survive a clone and that the copy is independent of the original.
Note: comments at the end of a section that are read by the parser are stored as leading comments of the next section, so
IniData.Clone()on parsed data was not affected in my checks. The loss occurs whenTrailingCommentsare set on aSectionDataand that section is cloned.Refs #156
🤖 Generated with Claude Code