Repository navigation
feat(embeddings): add embedding model support via Ollama API - #18
Merged
Merged
Conversation
rfprod
enabled auto-merge (squash)
October 29, 2026 16:21
rfprod
force-pushed
the
embeddings
branch
2 times, most recently
from
October 30, 2026 08:30
6016127 to
98a1e0f
Compare
rfprod
disabled auto-merge
October 30, 2026 08:31
- [x] add `embedding_model` parameter to configuration structs; - [x] add noninteractive UI methods (`print_error_noninteractive`, `print_success_noninteractive`); - [x] make `print_message_noninteractive()` a `static` method; - [x] replace `printf`/`fprintf` with proper UI output methods throughout; - [x] add emoji icons for improved UX messaging; - [x] add `--skip_embedding` command-line flag for optional embedding; - [x] rename `OllamaPromptConfig` to `OllamaClientConfig`; - [x] store config as member variable in `OllamaClient`; - [x] implement `generate_embeddings()` for vector generation with optional config; - [x] add `split_text()` utility for text chunking with overlap; - [x] fix embedding response parsing from `embedding` to `embeddings[0]`; - [x] fix embedding request payload field from `text` to `input`; - [x] create `EmbeddingUtils` class with document processing pipeline; - [x] move `curl` logic to reusable `CurlUtils` utility class; - [x] refactor `ollama_client` to use `curl_utils`; - [x] refactor `check_service_status` with `ProgressSpinner` integration; - [x] move `check_service_status` to private section; - [x] add `wait_for_service` with exponential backoff retry logic; - [x] add `fail_on_http_error` parameter to `fetch_web_content`; - [x] add `HttpException` class for detailed HTTP error handling; - [x] implement `qdrant_client` to enable vector database capabilities; - [x] add `collection_exists`, `delete_collection`, `create_collection` methods; - [x] refactor `store()` with collection lifecycle management; - [x] add validation for texts and embeddings size matching; - [x] implement `system_utils` for `system` call status handling; - [x] use `std::format` for standardized string formatting; - [x] add DEBUG conditional blocks for diagnostic output; - [x] fix typo: `requeest_payload` to `request_payload`; - [x] update VSCode extensions with Python and DevOps tools; - [x] add FAQ Commands section to README with setup instructions; - [x] add build script options (`--cxx-flags`, `--no-debug-flags`, `--exe-args`); - [x] add `get_project_root()` and `ensure_project_root()` script helpers; - [x] add `load_env_file()` to load `.env` configuration; - [x] add `CMAKE_CXX_FLAGS` and `EXECUTABLE_ARGS` environment variable support;
rfprod
enabled auto-merge (squash)
October 30, 2026 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
embedding_modelparameter to configuration structs;print_error_noninteractive,print_success_noninteractive);print_message_noninteractive()astaticmethod;printf/fprintfwith proper UI output methods throughout;--skip_embeddingcommand-line flag for optional embedding;OllamaPromptConfigtoOllamaClientConfig;OllamaClient;generate_embeddings()for vector generation with optional config;split_text()utility for text chunking with overlap;embeddingtoembeddings[0];texttoinput;EmbeddingUtilsclass with document processing pipeline;curllogic to reusableCurlUtilsutility class;ollama_clientto usecurl_utils;check_service_statuswithProgressSpinnerintegration;check_service_statusto private section;wait_for_servicewith exponential backoff retry logic;fail_on_http_errorparameter tofetch_web_content;HttpExceptionclass for detailed HTTP error handling;qdrant_clientto enable vector database capabilities;collection_exists,delete_collection,create_collectionmethods;store()with collection lifecycle management;system_utilsforsystemcall status handling;std::formatfor standardized string formatting;requeest_payloadtorequest_payload;--cxx-flags,--no-debug-flags,--exe-args);get_project_root()andensure_project_root()script helpers;load_env_file()to load.envconfiguration;CMAKE_CXX_FLAGSandEXECUTABLE_ARGSenvironment variable support;