Skip to content

feat(embeddings): add embedding model support via Ollama API - #18

Merged
rfprod merged 1 commit into
mainfrom
embeddings
Oct 30, 2026
Merged

rfprod merged 1 commit into
mainfrom
embeddings

Conversation

@rfprod

@rfprod rfprod commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner
  • add embedding_model parameter to configuration structs;
  • add noninteractive UI methods (print_error_noninteractive, print_success_noninteractive);
  • make print_message_noninteractive() a static method;
  • replace printf/fprintf with proper UI output methods throughout;
  • add emoji icons for improved UX messaging;
  • add --skip_embedding command-line flag for optional embedding;
  • rename OllamaPromptConfig to OllamaClientConfig;
  • store config as member variable in OllamaClient;
  • implement generate_embeddings() for vector generation with optional config;
  • add split_text() utility for text chunking with overlap;
  • fix embedding response parsing from embedding to embeddings[0];
  • fix embedding request payload field from text to input;
  • create EmbeddingUtils class with document processing pipeline;
  • move curl logic to reusable CurlUtils utility class;
  • refactor ollama_client to use curl_utils;
  • refactor check_service_status with ProgressSpinner integration;
  • move check_service_status to private section;
  • add wait_for_service with exponential backoff retry logic;
  • add fail_on_http_error parameter to fetch_web_content;
  • add HttpException class for detailed HTTP error handling;
  • implement qdrant_client to enable vector database capabilities;
  • add collection_exists, delete_collection, create_collection methods;
  • refactor store() with collection lifecycle management;
  • add validation for texts and embeddings size matching;
  • implement system_utils for system call status handling;
  • use std::format for standardized string formatting;
  • add DEBUG conditional blocks for diagnostic output;
  • fix typo: requeest_payload to request_payload;
  • update VSCode extensions with Python and DevOps tools;
  • add FAQ Commands section to README with setup instructions;
  • add build script options (--cxx-flags, --no-debug-flags, --exe-args);
  • add get_project_root() and ensure_project_root() script helpers;
  • add load_env_file() to load .env configuration;
  • add CMAKE_CXX_FLAGS and EXECUTABLE_ARGS environment variable support;

@rfprod rfprod self-assigned this Oct 29, 2026
@rfprod rfprod added Documentation Improvements or additions to documentation. Feature New feature implementation related changes. Program Main program logic related changes. labels Oct 29, 2026
@rfprod
rfprod enabled auto-merge (squash) October 29, 2026 16:21
@rfprod
rfprod force-pushed the embeddings branch 2 times, most recently from 6016127 to 98a1e0f Compare October 30, 2026 08:30
@rfprod
rfprod disabled auto-merge October 30, 2026 08:31
- [x] add `embedding_model` parameter to configuration structs;
- [x] add noninteractive UI methods (`print_error_noninteractive`, `print_success_noninteractive`);
- [x] make `print_message_noninteractive()` a `static` method;
- [x] replace `printf`/`fprintf` with proper UI output methods throughout;
- [x] add emoji icons for improved UX messaging;
- [x] add `--skip_embedding` command-line flag for optional embedding;
- [x] rename `OllamaPromptConfig` to `OllamaClientConfig`;
- [x] store config as member variable in `OllamaClient`;
- [x] implement `generate_embeddings()` for vector generation with optional config;
- [x] add `split_text()` utility for text chunking with overlap;
- [x] fix embedding response parsing from `embedding` to `embeddings[0]`;
- [x] fix embedding request payload field from `text` to `input`;
- [x] create `EmbeddingUtils` class with document processing pipeline;
- [x] move `curl` logic to reusable `CurlUtils` utility class;
- [x] refactor `ollama_client` to use `curl_utils`;
- [x] refactor `check_service_status` with `ProgressSpinner` integration;
- [x] move `check_service_status` to private section;
- [x] add `wait_for_service` with exponential backoff retry logic;
- [x] add `fail_on_http_error` parameter to `fetch_web_content`;
- [x] add `HttpException` class for detailed HTTP error handling;
- [x] implement `qdrant_client` to enable vector database capabilities;
- [x] add `collection_exists`, `delete_collection`, `create_collection` methods;
- [x] refactor `store()` with collection lifecycle management;
- [x] add validation for texts and embeddings size matching;
- [x] implement `system_utils` for `system` call status handling;
- [x] use `std::format` for standardized string formatting;
- [x] add DEBUG conditional blocks for diagnostic output;
- [x] fix typo: `requeest_payload` to `request_payload`;
- [x] update VSCode extensions with Python and DevOps tools;
- [x] add FAQ Commands section to README with setup instructions;
- [x] add build script options (`--cxx-flags`, `--no-debug-flags`, `--exe-args`);
- [x] add `get_project_root()` and `ensure_project_root()` script helpers;
- [x] add `load_env_file()` to load `.env` configuration;
- [x] add `CMAKE_CXX_FLAGS` and `EXECUTABLE_ARGS` environment variable support;
@rfprod
rfprod enabled auto-merge (squash) October 30, 2026 19:32
@rfprod rfprod added Enhancement Existing functionality improvement related changes. Refactor Refactoring related changes. labels Oct 30, 2026
@rfprod
rfprod merged commit 7fe5970 into main Oct 30, 2026
3 checks passed
@rfprod
rfprod deleted the embeddings branch October 30, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation. Enhancement Existing functionality improvement related changes. Feature New feature implementation related changes. Program Main program logic related changes. Refactor Refactoring related changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant