Skip to content

650 think aloud audio mic mute on demand reminders#1147

Merged
JackWilb merged 6 commits intodevfrom
650-think-aloud-audio-mic-mute-on-demand-reminders
Apr 7, 2026
Merged

650 think aloud audio mic mute on demand reminders#1147
JackWilb merged 6 commits intodevfrom
650-think-aloud-audio-mic-mute-on-demand-reminders

Conversation

@hilsonshrestha
Copy link
Copy Markdown
Contributor

@hilsonshrestha hilsonshrestha commented Mar 6, 2026

Does this PR close any open issues?

Closes #650

When mic is toggled off for more than 5 seconds, the mic icon starts blinking with tooltip shown until unmuted.
image

When mic is toggled off, but user is speaking, a message is displayed saying you are muted. This message goes away once unmuted or we hear no sound.
image

Give a longer description of what this PR addresses and why it's needed

  • Show warning When mic is toggled off for more than 5 seconds (blink mic + tooltip always visible)
  • Show notification when user is speaking but mic is turned off
  • Provenance Tracking of mic events
  • Display mic events in replay timeline

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

🪓 PR closed, deleted preview.

@hilsonshrestha hilsonshrestha requested a review from JackWilb March 6, 2026 21:04
@hilsonshrestha hilsonshrestha marked this pull request as ready for review March 6, 2026 21:04
@hilsonshrestha
Copy link
Copy Markdown
Contributor Author

Created a separate issue for provenance tracking of mic events: #1150

Copilot AI review requested due to automatic review settings March 18, 2026 22:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds “muted mic” reminders for think-aloud audio recording: a delayed visual mute warning (blinking mic + forced-open tooltip) and an “you are muted” notification when speech is detected while muted.

Changes:

  • Introduces shared helper utilities for deciding when to monitor muted audio and for consistent muted-instruction copy.
  • Extends recording hook state to (a) start a 5s “still muted” warning and (b) detect “speaking while muted” via an analyser on a cloned mic track.
  • Updates the header mic control to blink/show tooltip after 5s muted and to show/hide a persistent notification while speaking muted; updates demo config to exercise the feature.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/utils/recordingWarnings.ts New helpers for mute monitoring + instruction copy.
src/utils/recordingWarnings.spec.ts Unit tests for the new helpers.
src/utils/notifications.ts Makes showNotification return the notification id; adds hideNotification.
src/store/hooks/useRecording.ts Adds muted-warning timer + analyser-based “speaking while muted” detection; exposes new state.
src/components/interface/AppHeader.tsx Consumes new recording states to blink mic/force tooltip and show/hide a muted-speaking notification.
src/components/interface/AppHeader.module.css Adds blink animation class for the mic button.
public/demo-screen-recording/config.json Updates demo to include instructions and a click-to-record example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread public/demo-screen-recording/config.json Outdated
Comment thread src/components/interface/AppHeader.tsx Outdated
Comment thread src/components/interface/AppHeader.tsx Outdated
Comment thread src/components/interface/AppHeader.tsx
Comment thread public/demo-screen-recording/config.json Outdated
@JackWilb JackWilb merged commit 7fe4ffc into dev Apr 7, 2026
6 of 7 checks passed
@JackWilb JackWilb deleted the 650-think-aloud-audio-mic-mute-on-demand-reminders branch April 7, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants