Let users delete a specific job from a queue in the web UI#66
Open
reprah wants to merge 1 commit intoresque:masterfrom
Open
Let users delete a specific job from a queue in the web UI#66reprah wants to merge 1 commit intoresque:masterfrom
reprah wants to merge 1 commit intoresque:masterfrom
Conversation
|
+1 to have this merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature places a "Delete" button next to each job in a queue. When that button is clicked, the enqueued job is removed and the user is taken back to the queue's page.
Summary of my changes:
Here's an issue I want to bring up... since deleting a specific job relies on Resque::Job's class method
destroy(see here, please) some things might behave unexpectedly. Here's what I mean:There's one gem I found that gives UUIDs to Resque jobs (resque-status), but this gem would have to be present at the time someone creates a job and everyone would have to use this gem. We can't rely on that obviously.
The ball's in your court here, just let me know if there's a way I can improve this PR or if the above caveats make this a sort of undesirable feature. Thanks for taking the time to review this!