Develop class state (against develop)#224
Open
rburghol wants to merge 12 commits intorespec:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT READY TO MERGE (Reason: review of concepts pending) -- replaces #202
This PR includes an overhaul to the model
statesystem, leveraging a new object-oriented version ofstate, which accomplishes the following:statetakes the place ofstate_ix,dict_ix,ts_ix, ...tests/testcbp/HSP2results/to test a 500 equation addon simulation (Use:cp PL3_5250_0001.json.manyeq PL3_5250_0001.jsonto test).hydr()andsedtrn()to eliminate the argumentio_manageras this is no longer used (I think this has been due for a while, I don't think it is due to any changes that I recall making to the code but it seems like a cleaner approach)