-
Notifications
You must be signed in to change notification settings - Fork 20
Develop class state #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Develop class state #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformatted setup.py with 'black' auto formatter.
Changed package name from HSPsquared to hsp2 for a better name on pypi.
First attempt to initiate automated testing
try to change to node20 from node16
2nd try node.js
use v4 instead of v3 - does this fix node js 20 issue?
simplified tests using newer info from https://docs.github.com/en/enterprise-server@3.11/actions/automating-builds-and-tests/building-and-testing-python
try v5 since v4 still seems to be deprecated even though the docs "seem" to say going from 3 to 4 will fix.
try py 3.9
…uggests it should?)
ignore missing variables (since `_version` is loaded via an include). to fix CI script failure with code `F821` see respec#135 (comment)
ignore ACIDPH.py because it uses a weird sci notation format AC (i.e. I think `rkal1 = 1.03d-5` should be `rkal1 = 1.03e-5` etc)
Add update_uci mode in CLI and test UCI files
Develop if parser
….0 restriction in non-dev
Develop pandas3 prep
Closed
Contributor
|
This pull request should be to respec:develop not respec:master. |
Contributor
Author
|
If course you are right - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY TO MERGE (Reason: review of concepts pending) -- replaces #202
This PR includes an overhaul to the model
statesystem, leveraging a new object-oriented version ofstate, which accomplishes the following:statetakes the place ofstate_ix,dict_ix,ts_ix, ...tests/testcbp/HSP2results/to test a 500 equation addon simulation (Use:cp PL3_5250_0001.json.manyeq PL3_5250_0001.jsonto test).hydr()andsedtrn()to eliminate the argumentio_manageras this is no longer used (I think this has been due for a while, I don't think it is due to any changes that I recall making to the code but it seems like a cleaner approach)