Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge @PaulDudaRESPEC -- This PR restricts non-dev installs to be
< pandas 3.0.0, but adds code that is preliminarily valid for pandas 3.0.0. That is, code the will execute without error under pandas 3.0.0 and and this same code produces identical numerical results to hspf inpandas < 3.0.0. The test coverage that fails when run withpandas-3.0.0will be covered in #209 (Note: the test error IS related to pandas update, and is what I believe to be both an error in the test code, AND a legit simulation difference that needs to be scoped out -- elaborated on in the issue).This PR:
close()method to the custom localHDF5class (yes it is fine to have but no really needed per @austinorrwithstatement inrun()to insure clean handling in the event of an error in runtimeutilities.pyandmain.pyfrom Pandas 3.0, create new HDF5 close() method #216python < 3.11examples/pretest/cmd_regression.pythat creates a brief command prompt friendly tester, as well as leveraging the intermediate products of theRegressTestclass for simulation debugging.RegressTestin the filetests/convert/regression_base.pyto have a silent mode to be a bit more screen friendly (@austinorr this is False by default so no change in previous behavior is made).pandas-3.0.0errorpandas.errors.IndexingError: Unalignable boolean Series provided as indexer (index of the boolean Series and of the indexed object do not match). Again see Verify HSP* and Update RegressTest to run under Pandas 3.0.0 #209THIS IS NOT YET Pandas 3.0 safe. The change to pandas3 are substantial. Most specifically, there have been some things removed from classes, such as the
to_timedelta()method of the.deltaproperty of apandas.timerseries.freq, but most importantly, pandas no longer allowsTimedeltato have things likeY, orMme valid intervals, since they are non-ambiguous. Thus, I am not super optimistic about the IF-THEN constructs in theutilities.pytransform()function continuing to work since it looks at things like the string value of a frequency to see if they have the charactersYandM. The results look OK with test10, but I think we should consider that with more complicated datasets we could definitely encounter timeseries resampling issues. Or maybe not. We can track that in #209