fix: support for Cloudflare Workers, and other non-Node environments#820
Open
gabrielmfern wants to merge 4 commits intocanaryfrom
Open
fix: support for Cloudflare Workers, and other non-Node environments#820gabrielmfern wants to merge 4 commits intocanaryfrom
gabrielmfern wants to merge 4 commits intocanaryfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #817, swaps from using mailparser to using postal-mime which is actually meant to be used anywhere, without any dependencies. It has much, much fewer downloads, but socket gives it a good score, as well as the publisher for it is the same person as for mailparser, so I think we're safe to trust it.
The tests pass, and I've tried using it with a real email template and things seem to work properly.
Summary by cubic
Switched email parsing to PostalMime to support Cloudflare Workers and other non‑Node runtimes. Standardized attachment handling to base64 for consistent processing.
Dependencies
Refactors
Written for commit 0fafb2a. Summary will update on new commits.