feat: add raw url to types returned from inbound individual GET API#774
Open
lucasfcosta wants to merge 3 commits intocanaryfrom
Open
feat: add raw url to types returned from inbound individual GET API#774lucasfcosta wants to merge 3 commits intocanaryfrom
lucasfcosta wants to merge 3 commits intocanaryfrom
Conversation
isabellaaquino
approved these changes
Jan 2, 2026
gabrielmfern
approved these changes
Jan 2, 2026
commit: |
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/emails/receiving/receiving.spec.ts">
<violation number="1" location="src/emails/receiving/receiving.spec.ts:73">
P2: Invalid ISO 8601 timestamp: hour `24` with non-zero minutes/seconds (`24:13:52`) is not valid. If the intent is 1 hour after `created_at` (23:13), this should be `2023-04-08T00:13:52.669661+00:00` (midnight + 13 minutes on the next day).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| raw: { | ||
| download_url: | ||
| 'https://example.com/emails/raw/abc123?signature=xyz789', | ||
| expires_at: '2023-04-07T24:13:52.669661+00:00', |
Contributor
There was a problem hiding this comment.
P2: Invalid ISO 8601 timestamp: hour 24 with non-zero minutes/seconds (24:13:52) is not valid. If the intent is 1 hour after created_at (23:13), this should be 2023-04-08T00:13:52.669661+00:00 (midnight + 13 minutes on the next day).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/emails/receiving/receiving.spec.ts, line 73:
<comment>Invalid ISO 8601 timestamp: hour `24` with non-zero minutes/seconds (`24:13:52`) is not valid. If the intent is 1 hour after `created_at` (23:13), this should be `2023-04-08T00:13:52.669661+00:00` (midnight + 13 minutes on the next day).</comment>
<file context>
@@ -67,6 +67,11 @@ describe('Receiving', () => {
+ raw: {
+ download_url:
+ 'https://example.com/emails/raw/abc123?signature=xyz789',
+ expires_at: '2023-04-07T24:13:52.669661+00:00',
+ },
attachments: [
</file context>
✅ Addressed in 3aef7be
…the raw inbound preview with types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new types necessary for the feature-flagged option to download raw emails.
We don't need any change in functionality as these will work mostly like the download URLs for attachments, at least for now.
Please do not merge until the FF is enabled for all users.
Summary by cubic
Adds raw email download metadata to the inbound individual GET API types to enable raw email downloads behind a feature flag. Updates list types and tests; no runtime behavior change.
Written for commit 56d6fe4. Summary will update on new commits.