You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds discernible text to the landing page links. Currently, assistive technologies don't have any textual cue of what the images mean, so an sr-only span was added with "home", for the home page link in the React Email logo, and the name of the service for the integration section links. This is a necessary change to comply with WCAG's Sucess Criterion 1.4.2 - Name, Role Value (Level A).
Fun fact, some assistive technologies (like NVDA) workaround this missing information using the link's href and the page's title metadata, so they actually read these links fine in my main screen reader, but it's always nice to go with the most compatible approach to ensure wider compatibility and reap the SEO and AI benefits as well.
I am making this PR against main based on the contributing guide's instructions, since my last PR was merged into canary I believe it did not trigger a new deploy for the app.
Summary by cubic
Add sr-only labels to the home logo link and each integration link so screen readers announce meaningful labels. Improves accessibility and aligns with WCAG’s Name, Role, Value.
Written for commit 9a152c3. Summary will update on new commits.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
We're actually going to change that workflow of merging to main directly, mainly because want to avoid bringing in changes from main to canary, so I'm going to merge this into canary and move it to main in a bit. Again, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds discernible text to the landing page links. Currently, assistive technologies don't have any textual cue of what the images mean, so an
sr-onlyspan was added with "home", for the home page link in the React Email logo, and the name of the service for the integration section links. This is a necessary change to comply with WCAG's Sucess Criterion 1.4.2 - Name, Role Value (Level A).Fun fact, some assistive technologies (like NVDA) workaround this missing information using the link's
hrefand the page'stitlemetadata, so they actually read these links fine in my main screen reader, but it's always nice to go with the most compatible approach to ensure wider compatibility and reap the SEO and AI benefits as well.I am making this PR against
mainbased on the contributing guide's instructions, since my last PR was merged intocanaryI believe it did not trigger a new deploy for the app.Summary by cubic
Add sr-only labels to the home logo link and each integration link so screen readers announce meaningful labels. Improves accessibility and aligns with WCAG’s Name, Role, Value.
Written for commit 9a152c3. Summary will update on new commits.