Repository navigation
Add a ci-ok job that summarizes the CI result - #8899
Merged
Merged
Conversation
The ci-ok job needs build-compiler, pkg-pr-new, api-docs and both installation test matrices, and succeeds only when all of them succeeded. The master ruleset can then require ci-ok instead of matrix check names that contain runner labels, so moving to new runners or adding jobs no longer needs a ruleset change. Review: Why always() and not !cancelled()? A skipped required check counts as passed. With always() the job also runs when a needed job fails, is skipped or the run is cancelled, and then fails. Review: Which jobs stay outside the gate? dev-playground runs only on pushes to master, and test-devcontainer was not required before; neither blocks a merge. Area: ci Output: unchanged Tests: none, because the CI run on this pull request reports ci-ok Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014rR6jNpVHh7sx7L62iEf4u Signed-off-by: Christoph Knittel <ck@cca.io>
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8899 |
cknitt
marked this pull request as ready for review
October 18, 2026 12:40
fhammerschmidt
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
ci-okjob toci.ymlthat needsbuild-compiler,pkg-pr-new,api-docs,test-installation-npmandtest-installation-pnpm, and succeeds only when all of them succeeded. It runs withalways(), so a failed, skipped or cancelled job makes it fail rather than skip (a skipped required check counts as passed).After merging, the master ruleset can require
ci-ok,changelogandDCOinstead of the per-runner check names, so runner moves like #8891 or new jobs no longer need a ruleset change.🤖 Generated with Claude Code
https://claude.ai/code/session_014rR6jNpVHh7sx7L62iEf4u