Prune unused vendored Flow parser modules - #8593
Open
cknitt wants to merge 1 commit into
Open
Conversation
fhammerschmidt
approved these changes
Aug 28, 2026
cknitt
force-pushed
the
codex/prune-vendored-flow-parser
branch
from
August 28, 2026 18:39
4801df7 to
a0519c0
Compare
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
force-pushed
the
codex/prune-vendored-flow-parser
branch
from
August 28, 2026 19:41
a0519c0 to
da9b483
Compare
Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
force-pushed
the
codex/prune-vendored-flow-parser
branch
from
August 28, 2026 20:19
da9b483 to
13ed511
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8593 +/- ##
=======================================
Coverage 75.92% 75.92%
=======================================
Files 475 475
Lines 63015 63029 +14
=======================================
+ Hits 47842 47854 +12
- Misses 15173 15175 +2 🚀 New features to boost your workflow:
|
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8593 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes approximately 4,450 lines, or 12% of the vendored OCaml sources.
Further mechanical pruning is not feasible because ReScript uses the parser for both complete JavaScript programs and individual expressions in
%raw. The Flow parser connects expression parsing transitively to statements, declarations, types, JSX, patterns, comments, and its shared AST.Removing substantially more would therefore require disabling accepted syntax or restructuring the parser, rather than simply deleting unused modules. That would need a clearly defined
%rawJavaScript syntax contract and broader parser-specific test coverage.This is the fifth PR in the “Flow Forward” series, stacked on the OCaml 5.5 toolchain upgrade.
Related to #8567.