Upgrade the development toolchain to OCaml 5.5 - #8589
Conversation
862cd1d to
a846121
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/upgrade-ocamlformat-0.29 #8589 +/- ##
=================================================================
Coverage ? 75.92%
=================================================================
Files ? 475
Lines ? 63029
Branches ? 0
=================================================================
Hits ? 47854
Misses ? 15175
Partials ? 0
🚀 New features to boost your workflow:
|
a846121 to
f14e320
Compare
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
99a735f to
0420f15
Compare
cristianoc
left a comment
There was a problem hiding this comment.
what are the formatting changes?
Caused by upgrading ocamlformat. |
That seems like a lot of churn on ocamlformat part. Strange. Isn't there a setting so we don't change everything? |
cristianoc
left a comment
There was a problem hiding this comment.
Looks like there's no easy way out of the churn. If it turns out that there is, great. If not, OK.
|
I checked this. OCamlformat 0.27 is constrained to OCaml <5.4, so we cannot keep it in the OCaml 5.5 toolchain. The newer formatter has changed some formatting rules, and there does not appear to be a compatibility setting for preserving the 0.27 output. I also tried restoring the previous To keep the OCaml 5.5 PR reviewable, I suggest moving the OCamlformat upgrade and mechanical reformatting into a separate PR in the stack. |
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
0420f15 to
aa9d92d
Compare
Summary
ocaml >= 5.0.0as the package constraint and keep the dedicated OCaml 5.0 compatibility CI jobFormatbehavior change while keeping syntax-test output stableThis is the fourth PR in the "Flow Forward" series. It is stacked on the OCamlformat 0.29 upgrade so the mechanical reformat and toolchain changes remain independently reviewable.
Related to #8567.