Skip to content

Upgrade vendored Flow parser to 0.320.0 - #8588

Open
cknitt wants to merge 6 commits into
masterfrom
codex/upgrade-flow-parser-last-ocaml
Open

Upgrade vendored Flow parser to 0.320.0#8588
cknitt wants to merge 6 commits into
masterfrom
codex/upgrade-flow-parser-last-ocaml

Conversation

@cknitt

@cknitt cknitt commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

  • upgrade the vendored Flow parser from 0.267.0 to 0.320.0, the final release of the OCaml implementation
  • update the vendored source set and provenance documentation
  • retain ReScript's private Dune integration and existing compiler-facing interface
  • keep dependency and OCaml upgrades out of this PR

This is the second PR in the "Flow Forward" series. Updating the parser separately gives us a stable base before changing the OCaml toolchain.

Related to #8567.

cknitt added 2 commits August 28, 2026 10:16
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7091dc2e6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread compiler/flow_parser/collections/iMap.ml Outdated
Comment thread compiler/flow_parser/parser/parse_error.ml
Comment thread compiler/flow_parser/README.md Outdated
cknitt added 3 commits August 28, 2026 10:27
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.92%. Comparing base (afdaaa8) to head (53a429b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8588   +/-   ##
=======================================
  Coverage   75.91%   75.92%           
=======================================
  Files         475      475           
  Lines       63033    63033           
=======================================
+ Hits        47853    47859    +6     
+ Misses      15180    15174    -6     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Christoph Knittel <ck@cca.io>
@pkg-pr-new

pkg-pr-new Bot commented Aug 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8588

@rescript/belt

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/belt@8588

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8588

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8588

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8588

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8588

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8588

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8588

commit: 53a429b

@github-actions

Copy link
Copy Markdown

@cristianoc

Copy link
Copy Markdown
Collaborator

I guess the flow parser will be aggressively cut to only what's needed by the compiler after this. And that most of it will just go, leaving the rest easy to maintain via agents in future if required.

@cknitt

cknitt commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

I guess the flow parser will be aggressively cut to only what's needed by the compiler after this. And that most of it will just go, leaving the rest easy to maintain via agents in future if required.

Or possibly moved to JSOO's JS parser if feasible. See #8567.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants