Repository navigation
fix(webapi): correct native binding contracts [Codex] - #399
Draft
jderochervlk wants to merge 13 commits into
Draft
jderochervlk wants to merge 13 commits into
jderochervlk wants to merge 13 commits into
Conversation
…o agent/alpha-binding-contracts
…o agent/alpha-binding-contracts
…o agent/alpha-binding-contracts
…o agent/alpha-binding-contracts
…o agent/alpha-binding-contracts
21 tasks
Collaborator
Author
|
Independent review of 5ce03b4, against 1a6aceb (#397 foundation). Not acceptance-complete; no approval/merge performed. All seven requested checks pass, but the following P2 regression/evidence defects need attention:
Additional acceptance gaps beyond the draft's acknowledged stream-chunk, shared/service-worker runtime, IIR call, and permission-value gaps:
Checks executed successfully: |
…o agent/alpha-binding-contracts
This was referenced Nov 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stacked batch corrects native API representations, receiver dispatch, callback arity, and nullable/empty result contracts for #386–#392. The changes preserve native throws and rejections and avoid implicit copies: byte readers and stream chunks use Uint8Array, Web Audio and matrix APIs use native typed arrays, and native output methods write into the buffers supplied by callers.
The batch also corrects ResizeObserver argument shape; WebCrypto’s fixed results and public typed workflows; CustomElementRegistry constructor, broad closest, and HTML/SVG className contracts; and the empty, nullable, static, and operation-specific result cases.
For WebCrypto, generic algorithm-dependent generation/export is honestly
unknown; the supported precise helpers fix HMAC key generation and ECDSA key-pair generation by algorithm, and split binary and JWK export by disjoint format types. Positive packed-consumer compilation and native Chromium workflows cover generate/sign/verify/digest-to-byte-view/export and key-pair signing without unsafe casts. Negative packed consumers reject wrong algorithm/format assumptions.The native regressions now use only local fixtures: WebSocket text/ArrayBuffer/Blob sends reach a real loopback echo server; Worker Request fetch runs in a real worker against a local HTTP server that checks the forwarded POST method, header, and body; ResizeObserver observes an actual resize and disconnects; Blob stream chunks, SafeFetch bytes/identity, offline audio buffers and filters, non-identity DOMMatrix conversions, custom elements/closest/SVG, and the issue #392 native edge cases are asserted.
This PR is stacked on foundation PR #397 and uses its
agent/alpha-tooling-releasebranch at6fa3016a58700c1986acc705f7ff851efc54709e. It intentionally does not duplicate harness, packaging, workflow, or documentation foundation changes. The documentation PR #398 is downstream and remains docs-only. SharedWorkerScope and ServiceWorkerScope Request-fetch inherited bindings are compile-checked; the native Request-fetch run uses the base Worker scope.Refs #386, #387, #388, #389, #390, #391, #392