Skip to content

Fix traffic row highlight after closing details pane#59

Open
VickTor61 wants to merge 1 commit into
requestly:masterfrom
VickTor61:fix/virtual-table-highlight
Open

Fix traffic row highlight after closing details pane#59
VickTor61 wants to merge 1 commit into
requestly:masterfrom
VickTor61:fix/virtual-table-highlight

Conversation

@VickTor61
Copy link
Copy Markdown

Closes issue: #51

📜 Summary of changes:

  • Fixed traffic table row highlight staying active after closing the request details pane.
  • Lifted selected row state to TrafficTableV2/index.jsx.
  • Passed selectedRowId down through GroupByNone, NetworkInspector, NetworkTable, and VirtualTableV2.
  • Added onSelectedRowChange handler instead of passing the state setter directly.
  • Updated VirtualTableV2 to use controlled row selection.
  • Cleared the selected row id in handleClosePane, removing the blue highlight when the pane closes.

🎥 Demo Video:

Screen.Recording.2026-06-04.at.10.33.45.PM.mov

✅ Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events if applicable.
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation if already exists.
  • Added demo video showing the changes in action.

🧪 Test instructions:

  1. Run the web app locally.

  2. Run the Requestly desktop Electron app against the local web app.

  3. Generate traffic through the Requestly proxy, for example:

    curl --proxy http://127.0.0.1:8281 http://example.com/

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 4, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants