Skip to content

[Bug] Query parameter rules drop equals signs from existing values #121

Description

@jashkarangiya

Is this about Requestly HTTP Interceptor?

  • Yes, this is about the HTTP Interceptor

What happened?

Query parameter rules lose equals signs that are part of an existing value.

For example, modifying https://example.com?token=abc==&remove=1 parses token as abc. Adding another parameter, or removing the unrelated remove parameter, then rebuilds the URL without the trailing equals signs.

I expected Requestly to split each query parameter on the first equals sign and preserve everything after it as the value.

Steps to reproduce

To reproduce while adding a parameter:

  1. Create a Query Param rule that adds added=2.
  2. Apply it to https://example.com?token=abc==&remove=1.
  3. The rebuilt URL loses the trailing equals signs from token.

To reproduce while removing a parameter:

  1. Create a Query Param rule that removes remove.
  2. Apply it to https://example.com?token=abc==&remove=1.
  3. The result should be https://example.com?token=abc==, but the trailing equals signs are dropped.

Where does the bug happen?

  • Browser extension (Chrome / Firefox / Edge / Safari)
  • Web app (app.requestly.com)

Browser (if extension)

  • Chrome
  • Firefox
  • Edge
  • Safari

Operating system (if desktop or relevant)

N/A

Version

  • Current master: 700da5b
  • Extension: 26.7.27

Which area?

rules (redirect, modify headers, replace, etc.)

Logs / screenshots / HAR

Not applicable. This happens in the shared query parameter parser.

Anything else?

A small fix and regression tests for both add and remove operations are ready.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions