Bug Fix in TVWindow related to ComboBox#1
Open
WolfieWerewolf wants to merge 3 commits intoreportmill:masterfrom
WolfieWerewolf:master
Open
Bug Fix in TVWindow related to ComboBox#1WolfieWerewolf wants to merge 3 commits intoreportmill:masterfrom WolfieWerewolf:master
WolfieWerewolf wants to merge 3 commits intoreportmill:masterfrom
WolfieWerewolf:master
Conversation
Owner
|
Is this in the latest source? MenuButtons seem to work fine, but I guess I don’t have any demos on the site for ComboBox.
I’m not sure how much more work I’ll be doing with TVM though. :-)
jeff
… On Jul 14, 2017, at 8:32 AM, WolfieWerewolf ***@***.***> wrote:
'''java
// Add canvas
HTMLDocument doc = HTMLDocument.current();
HTMLBodyElement body = doc.getBody();
if(doc.getElementsByTagName("canvas").getLength() > 1){
body.removeChild(canvas);
}
'''
Without this the combo box fails to open on the second user click. I know this pull request includes the Maven stuff, I don't know how to selectively submit pulls.. but you may want to pull that as well I don't know. You could easily merge this change manually.
You can view, comment on, or merge this pull request online at:
#1 <#1>
Commit Summary
Added Maven Support
Merged IDEA tools from curent 0.6.0 master to our fork
Bug fix in TV Window related to ComboBox, only hide the canvas if
File Changes
A .idea/vcs.xml <https://github.com/reportmill/SnapTea/pull/1/files#diff-0> (6)
A SnapTea.iml <https://github.com/reportmill/SnapTea/pull/1/files#diff-1> (18)
A pom.xml <https://github.com/reportmill/SnapTea/pull/1/files#diff-2> (43)
R src/main/java/org/teavm/classlib/java/util/TScanner.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-3> (0)
R src/main/java/org/teavm/classlib/java/util/concurrent/TCopyOnWriteArrayList.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-4> (0)
R src/main/java/org/teavm/classlib/java/util/function/TIntConsumer.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-5> (0)
R src/main/java/org/teavm/classlib/java/util/stream/TIntStream.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-6> (0)
R src/main/java/snaptea/TV.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-7> (0)
R src/main/java/snaptea/TVEnv.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-8> (12)
R src/main/java/snaptea/TVEvent.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-9> (0)
R src/main/java/snaptea/TVFontFile.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-10> (0)
R src/main/java/snaptea/TVImage.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-11> (0)
R src/main/java/snaptea/TVLock.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-12> (0)
R src/main/java/snaptea/TVPainter.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-13> (0)
R src/main/java/snaptea/TVRootView.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-14> (0)
R src/main/java/snaptea/TVScreen.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-15> (0)
R src/main/java/snaptea/TVSoundClip.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-16> (0)
R src/main/java/snaptea/TVViewEnv.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-17> (0)
R src/main/java/snaptea/TVWebSite.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-18> (0)
R src/main/java/snaptea/TVWindow.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-19> (9)
R src/main/java/snaptea/Touch.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-20> (0)
R src/main/java/snaptea/TouchEvent.java <https://github.com/reportmill/SnapTea/pull/1/files#diff-21> (0)
Patch Links:
https://github.com/reportmill/SnapTea/pull/1.patch <https://github.com/reportmill/SnapTea/pull/1.patch>
https://github.com/reportmill/SnapTea/pull/1.diff <https://github.com/reportmill/SnapTea/pull/1.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#1>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJP8SnvgJLxBKXn8R1KJAGOCpjd1Lpjcks5sN232gaJpZM4OYQe4>.
|
Collaborator
Author
|
This is the latest as of yesterday when I forked it... Alexey is going to be so sad :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'''java
// Add canvas
HTMLDocument doc = HTMLDocument.current();
HTMLBodyElement body = doc.getBody();
'''
Without this the combo box fails to open on the second user click. I know this pull request includes the Maven stuff, I don't know how to selectively submit pulls.. but you may want to pull that as well I don't know. You could easily merge this change manually.