Repository navigation
feat(badge-buddy)!: use MCP for BadgeApp interactions - #7
Draft
hesreallyhim wants to merge 1 commit into
Draft
hesreallyhim wants to merge 1 commit into
hesreallyhim wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace badge-buddy's duplicate BadgeApp CLI with the published best-practices-mcp 0.5.0 server, registered through the plugin's
.mcp.json. Skills now use MCP project discovery, selected-project reads, explicit draft construction/validation and proposal URLs with exact overrides. Optional server-managed drafts remain optional; existing assessment JSON can be reused without automatic migration or merging.The migration plan was reviewed before implementation and is recorded in
docs/planning/badge-buddy-mcp-migration.md. All advisory references, bundled display criteria/examples and local preview assets remain. A standalone offlinereview_board.pyrenders all six badge levels and rejects a conflicting numeric draft/project ID before writing output. Browser review and website save remain user-controlled.Remove
ossf.py, its duplicate synchronization/storage/submission implementation and console-fill generator, along with tests specific to those retired paths. Scorecard's shared GitHub remote normalizer is extracted; AST comparison confirmed its only semantic change is the import module. Required formatter output accounts for the larger Scorecard diff.The dependent
badge-progressmod previously parsed the deleted CLI's Bash output. It now displays an explicit transition notice and stops restoring stale counts. The retained local preview board remains available. A future progress adapter needs documented host MCP events and separate draft/saved-state semantics; no CLI fallback was added.Validation:
make checkpassed 180 tests plus compilation; two progress-mod tests passed; both plugin validators passed with nonblocking icon/install-example warnings; formatting, JSON and tree checks passed. The pinned published executable returned version 0.5.0 after refreshing a stale uv cache. Independent review found a board identity mismatch, now fixed and covered by tests.Review/install the feature branch and reload the host to qualify automatic MCP registration. Plugin manifest versions are unchanged for the maintainer's release decision; no plugin release was published.