feat: readable rb ffprobe output#110
Merged
Merged
Conversation
a-essawy
enabled auto-merge (squash)
July 19, 2026 05:11
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rb ffprobecurrently prints a single terse line on success (e.g.Video mp4 0:05 1280x720 24fps), dropping almost every useful field the probe actually returns. This replaces it with a clean, multi-line summary block.formatSummaryBlock()renders a header line (kind, container, duration, size) plus a labeled row per stream kind (Video/Audio/Image), adapting to what the media actually has:undefinedresolveOutputText()handles the two shapesoutput.datacan take: a parsedsummaryrenders the block above; asummary-less response (raw-print_format csv/xml/-of default) printsoutput.data.stdoutverbatim instead, since that's exactly what the user asked ffprobe for.--jsonstill prints the fulloutput.data, and the trailing dashboard job URL line is unchanged.ProbeSummary/ProbeDatalocal types to match the fuller documentedoutput.datacontract (profile, displayAspectRatio, bitDepth, channelLayout, sampleRate, isHdr, rotation, language, etc.) instead of the minimal subset the old one-liner used.Test plan
pnpm typecheckcleanpnpm test— 174 pass, 0 fail