Repository navigation
Register WP-CLI subcommands under their documented hyphenated names - #59
Merged
Merged
Conversation
WP-CLI names subcommands after the method unless @subcommand says otherwise, so 'wp rfsd purge-transients' (as documented in readme.txt and README.md) failed with 'not a registered subcommand'. The underscore names stay available as aliases. Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
9 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
I found this while testing 4.0.0 by hand in a throwaway WordPress container.
readme.txtandREADME.mddocumentwp rfsd purge-transients,wp rfsd process-queueandwp rfsd queue-info. WP-CLI names a subcommand after its method, though, so the commands only existed aspurge_transientsetc. The documented forms failed:3.x had the same problem (
wp fqj …). Each method now has@subcommand <hyphenated-name>, plus@alias <underscore_name>so anything already using the underscore form keeps working.No version bump: this should go out with the next release after 4.0.0, which is the version under WordPress.org review.
Type of Change
Checklist
Testing Instructions
composer lint: cleancomposer test: 306 OKcomposer test:multisite: 318 OKtest-cli.phpchecks each method's@subcommandand@aliastags, and that the readme documents the hyphenated name.wp rfsd purge-transients,wp rfsd purge_transients,wp rfsd process-queue --limit=10andwp rfsd queue-infoall succeed.🤖 Generated with Claude Code