Repository navigation
Address WordPress.org review: rename to Renderbit FAQ Structured Data (4.0.0) - #58
Merged
Merged
Conversation
…ct2 4.1.0 - Register FAQs as `fqj_faq` (FQJ_POST_TYPE) instead of the generic `faq_item`. fqj_migrate_legacy_post_types() renames rows stored under a type in FQJ_LEGACY_POST_TYPES once per site, on plugins_loaded priority 5 and on activation, so the schema upgrade, data migration 3 and the activation FAQ check all see the new type. Uninstall deletes both types. - Show the queue notice only on the plugin's own screens (Guideline 11), and make its text translatable. - Update the bundled Select2 from 4.0.13 to 4.1.0. - Bump to 3.1.1. Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 203 |
| Duplication | 9 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be884f2c97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
WordPress.org review: the name and slug were too generic, and prefixes must be at least 4 characters. Plugin name, slug and text domain become renderbit-faq-structured-data; every fqj_/FQJ_/fqj- name becomes rfsd_/RFSD_/rfsd-, including the CPT (rfsd_faq), tables, options, meta, hooks, public filters, AJAX actions, JS globals and the WP-CLI command (wp rfsd). The main file is renderbit-faq-structured-data.php. Co-Authored-By: Claude <noreply@anthropic.com>
The new slug makes this a separate plugin, so sites switch by installing it next to FAQ JSON-LD Manager. rfsd_import_legacy_data() runs once per site (plugins_loaded priority 5 and activation) and: - moves faq_item posts and their association meta to rfsd_faq, so the old plugin stops printing duplicate FAQPage output and its uninstall cannot delete them; - copies settings, the URL migration report and the mapping rows (with the data version only when rows were copied, so migration 3 still sees the old post rows; otherwise the data migration reindexes everything); - clears the old plugin's cron events. Uninstall no longer deletes faq_item posts, which belong to the old plugin. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
soham2008xyz
changed the title
…t2 4.0 result styles - rfsd_import_legacy_data() now requires fqj_db_version or fqj_settings, which only FAQ JSON-LD Manager writes, so another plugin's faq_item posts are never taken over. - When a reused Select2 script has no known stylesheet, the bundled 4.1 CSS gets the 4.0 aria-selected result rules inline, so the highlighted and selected results stay visible. Co-Authored-By: Claude <noreply@anthropic.com>
The JS file renames made Codacy report the existing no-undef (rfsdAdmin, rfsdHealth from wp_localize_script) and no-redeclare (select) findings as new. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes everything raised in the WordPress.org Plugin Directory review of the 3.0.1 submission ("Review in Progress: FAQ JSON-LD Manager", 2026-10-20).
Name, slug and prefix (commit c716dc6)
renderbit-faq-structured-dataand main filerenderbit-faq-structured-data.php.fqj_/FQJ_/fqj-name is nowrfsd_/RFSD_/rfsd-. That covers functions, constants, the CPT (rfsd_faq), tables, options, meta keys, cron hooks, AJAX actions, nonces, menu slugs, script handles, JS globals, public filters and the WP-CLI command (wp rfsd, classRFSD\Rfsd_Cli).fqj_*filter aliases are kept. The changelog lists the new names.Import from the old plugin (commit e5b9ffc)
rfsd_import_legacy_data()runs once per site, onplugins_loadedpriority 5 and on activation (on every site with network activation), and:faq_itemposts and theirfqj_assoc_*meta torfsd_faq/rfsd_assoc_*. The old plugin then stops printing duplicate FAQPage output, and its uninstall can't delete them;postrows; with no rows copied, the data migration reindexes every FAQ;rfsd_legacy_storage_names().faq_itemposts.Other review items (commit be884f2, carried over)
Release (commit fe06ad6)
Type of Change
Checklist
Testing Instructions
composer lint: cleancomposer test: 302 OKcomposer test:multisite: 314 OKnpm test: 31 OKcomposer build-zip && composer check-zip: OK; the zip folder isrenderbit-faq-structured-data/tests/php/test-legacy-import.phpcovers:test-multisite.phpcovers network activation.By hand: on a site running FAQ JSON-LD Manager 3.x with some FAQs, install this zip next to it and activate it. Check that the FAQs appear under the new menu and print JSON-LD once on their posts. Then deactivate and delete the old plugin, and check that nothing is lost.
Additional Notes
deploy-wporg.ymlnow deploys to therenderbit-faq-structured-dataSVN slug. WordPress.org has to approve that slug first.🤖 Generated with Claude Code