Repository navigation
fix(nav): float the empty navigation over the hero on phones - #359
Merged
Merged
Conversation
On phones and tablets the navigation is empty at the top of the page, yet it pushed the hero down by its 60px, on top of the hero's own margin. It now floats over the hero, transparent, until the page scrolls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On screens up to 920px, the navigation is empty at the top of the page (no links; the name and button are still in the hero), yet it pushed the hero down by 60px. It now floats over the hero, transparent, and takes its background back once the page scrolls. Without JavaScript it keeps its place. Desktop is unchanged.
A new test checks the name starts within 48px of the top on a phone, and that the navigation has its background once scrolled.
🤖 Generated with Claude Code