Repository navigation
Conversation
Assisted-by: Opus 4.6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 93.24% 93.26% +0.01%
==========================================
Files 57 57
Lines 4711 4721 +10
Branches 300 300
==========================================
+ Hits 4393 4403 +10
Misses 260 260
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| _log.debug( | ||
| "Emitting Kafka message to %s headers=%s body=%s", topic, headers, body | ||
| ) |
There was a problem hiding this comment.
I remember we have been logging the messages before, but it is not a good idea (it is a lot of data), unless they are logged in a trace log level disabled by default.
There was a problem hiding this comment.
WDYT about keeping only header then?
There was a problem hiding this comment.
If this is related to verifying if the UMB message contains the right headers (because this should be handled by bridge), then it would be better to test it manually (e.g. set up a temporary UMB message consumer locally).
But I don't think this is important for anyone else but Datagrepper which is getting decommissioned anyway.
2 participants
Add a debug log before emitting message and an info log when message was accepted by a broker