Repository navigation
Add Kafka listener - #511
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 92.53% 93.24% +0.71%
==========================================
Files 55 57 +2
Lines 4272 4711 +439
Branches 270 300 +30
==========================================
+ Hits 3953 4393 +440
+ Misses 264 260 -4
- Partials 55 58 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fe49bad to
7af4275
Compare
|
@hluk if you find it good, feel free to immediately merge it, let's merge it ASAP. |
hluk
left a comment
hluk
left a comment
There was a problem hiding this comment.
Can you update message-broker in docker-compose.yml and configuration for waiverdb and resultsdb in compose env so it uses Kafka instead?
7af4275 to
3f5d15a
Compare
Done |
3f5d15a to
5d9de37
Compare
| def _listen_kafka(self): | ||
| from greenwave.listeners.kafka import KafkaBus | ||
|
|
||
| with self.connection_condition: |
There was a problem hiding this comment.
The block is probably not needed here since the thread should not be running yet.
But it should have similar "Already connected" check as in _listen_stomp.
5d9de37 to
162495c
Compare
| } | ||
| if self._backend == "kafka": | ||
| try: | ||
| self._kafka_bus.publish(self.destination, body, headers) |
There was a problem hiding this comment.
This is also missing with self.connection_condition
JIRA: RHELWF-13776 Assisted-by: Opus 4.6
162495c to
154ebc8
Compare
2 participants
JIRA: RHELWF-13776
Assisted-by: Opus 4.6