Skip to content

Fix bitcoin dead address#1055

Merged
pedromcunha merged 5 commits into
mainfrom
fix/bitcoin-dead-address
Jul 1, 2026
Merged

Fix bitcoin dead address#1055
pedromcunha merged 5 commits into
mainfrom
fix/bitcoin-dead-address

Conversation

@pedromcunha

Copy link
Copy Markdown
Member

No description provided.

@pedromcunha pedromcunha requested a review from ted-palmer July 1, 2026 02:42
@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
relay-sdk-demo Building Building Preview, Comment Jul 1, 2026 2:42am

Request Review

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 37s —— View job


Code Review

Code Review — 1 issue found

  1. [NOTE] Repo guidelines: Duplicate changesets for one fix
    .changeset/sharp-colts-dance.md and .changeset/shiny-webs-doubt.md both add a @relayprotocol/relay-sdk patch describing the same Bitcoin dead-address fix ("Fix BTC dead address preview error" / "Fix bitcoin dead address"). They're harmless (changesets merge on release) but redundant — consider removing one so the release notes don't list the same fix twice.

Correctness — the swap from 1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa to 34xp4vRoCGJym3xR7yCVPFHoCNxv4Twseo is a single-constant change. Both consumers, getDeadAddress() (packages/sdk/src/constants/address.ts:22) and isDeadAddress() (address.ts:42), reference the constant, so they stay in sync automatically. The two UI checks in TokenSelector.tsx:221 and PaymentMethodTrigger.tsx:35 also import the constant, so no hardcoded copies were left behind. The new value is a valid mainnet P2SH address, consistent with the fix's intent of resolving the preview/quote error the old P2PKH genesis address triggered.

No security or error-handling concerns.

Reviewed 3 files, 11 lines changed. Checked correctness, security, error handling, and repo guidelines compliance.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Claude finished @pedromcunha's task in 27s —— View job


📝 Docs Drift Check — No docs impact

This PR does not touch surfaces that require a relayprotocol/relay-docs update.

@pedromcunha pedromcunha requested a review from d3or July 1, 2026 02:42
@pedromcunha pedromcunha merged commit 88a63b6 into main Jul 1, 2026
5 of 6 checks passed
@pedromcunha pedromcunha deleted the fix/bitcoin-dead-address branch July 1, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants