refactor(sdk): convert convertViemChainToRelayChain to function declaration#1045
Merged
Merged
Conversation
Contributor
|
@HerringtonDarkholme is attempting to deploy a commit to the Uneven Labs Team on Vercel. A member of the Team first needs to authorize it. |
HerringtonDarkholme
force-pushed
the
main
branch
from
c1b566f to
3bf4cfb
Compare
pedromcunha
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: relay-sdk has a circular import: client.js → utils/index.js → executeSteps/index.js (+ transaction.js, viemWallet.js) → back to client.js.
And client.js calls convertViemChainToRelayChain at module-eval top level:
This will break some bunlders like vite.
This PR changes it to use function declaration instead to create a forward reference.