Add run_constrained support to grayskull dependency updates#5646
Open
ctcjab wants to merge 1 commit intoregro:mainfrom
Open
Add run_constrained support to grayskull dependency updates#5646ctcjab wants to merge 1 commit intoregro:mainfrom
ctcjab wants to merge 1 commit intoregro:mainfrom
Conversation
The update-grayskull inspection feature now updates run_constrained dependencies when bumping package versions. This prevents stale version constraints that can break downstream packages. Changes: - Add "run_constrained" to SECTIONS_TO_PARSE - Add new SECTIONS_TO_UPDATE_CONSTRAINTS_ONLY for conservative updates - Add constraints_only parameter to _apply_env_dep_comparison() - Update _apply_dep_update_v1() and apply_dep_update() to handle run_constrained with constraints-only behavior - Update generate_dep_hint() to show run_constrained updates The constraints-only behavior for run_constrained: - Updates version constraints for packages in both recipe and grayskull - Does NOT add new packages (optional deps are maintainer's choice) - Does NOT remove packages (maintainer may have specific reasons) This fixes issues like litellm-feedstock where uvicorn constraint was stale (>=0.31.1,<0.32.0) instead of upstream's (>=0.32.1,<1.0.0). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
beckermr
requested changes
Mar 1, 2026
Contributor
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
This PR needs testing against v1 recipes. Those recipes put run constraints in a different part of the recipe.
| # For host/run sections: show add/remove suggestions | ||
| df_cf = "" | ||
| for sec in SECTIONS_TO_PARSE: | ||
| for sec in ["host", "run"]: # Exclude run_constrained from add suggestions |
Contributor
There was a problem hiding this comment.
This set of sections should be made a constant above. Maybe we call it SECTIONS_TO_HINT?
Author
|
@beckermr thanks for the quick review! Since I am not sure when I'll have time to pick this back up, anyone reading this please feel free to take over here. Happy to grant anyone permission to push to my branch as needed. |
Contributor
|
OK. happy to wait on this PR until you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
update-grayskullinspection feature now updatesrun_constraineddependencies when bumping package versions. This prevents stale version constraints that can break downstream packages.Changes:
"run_constrained"toSECTIONS_TO_PARSESECTIONS_TO_UPDATE_CONSTRAINTS_ONLYconstant for conservative updatesconstraints_onlyparameter to_apply_env_dep_comparison()_apply_dep_update_v1()andapply_dep_update()to handlerun_constrainedgenerate_dep_hint()to showrun_constrainedupdatesThe constraints-only behavior for
run_constrained:This conservative approach fixes stale constraints while respecting maintainer decisions about which optional dependencies to include.
Checklist:
Cross-refs, links to issues, etc:
Fixes #5645
Real-world example: litellm-feedstock had stale uvicorn constraint
>=0.31.1,<0.32.0instead of upstream's>=0.32.1,<1.0.0, breaking packages likenotebook_intelligence.