fix(components): drop dead datadisplay lazy exports - #7124
Draft
benedikt-bartscher wants to merge 1 commit into
Draft
fix(components): drop dead datadisplay lazy exports#7124benedikt-bartscher wants to merge 1 commit into
benedikt-bartscher wants to merge 1 commit into
Conversation
`reflex_components_core.datadisplay` still lazy-attached `code` and
`dataeditor` submodules, but those shipped out to the standalone
reflex-components-code and reflex-components-dataeditor packages, so
nothing under `reflex_components_core/datadisplay/` provides them:
>>> import reflex_components_core.datadisplay as dd
>>> dd.code_block
ModuleNotFoundError: No module named
'reflex_components_core.datadisplay.code'
The generated stub inherited the same dead entries and imported `.code`
and `.dataeditor`, which pyright reports as unresolved imports.
The names users reach for keep working: `rx.code_block` /
`rx.data_editor` resolve against the new packages, and
`reflex.components.datadisplay.code` is redirected there by the import
hook in `reflex/components/__init__.py` — both covered by the new tests.
Contributor
 |
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.