-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Improve docs indexing, accessibility, and initial load performance #7078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
654132a
Improve docs indexing, accessibility, and initial load performance
Alek99 fe56d43
Address docs review findings and isolate CI fixtures
Alek99 f2a0f43
Use configured docs URLs and run frontend regressions in CI
Alek99 4aaf0f9
Hide the Built with Reflex badge on the docs site
Alek99 a7e412a
Keep docs deployment URLs environment-driven and fix API sidebar casing
Alek99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Improve documentation search metadata, structured breadcrumbs, legacy redirects, responsive reference tables, and accessible examples. Remove marketing trackers from documentation pages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| """Permanent redirects for renamed documentation pages.""" | ||
|
|
||
| from collections.abc import Sequence | ||
|
|
||
| from starlette.responses import RedirectResponse | ||
| from starlette.types import ASGIApp, Receive, Scope, Send | ||
|
|
||
|
|
||
| class DocsRedirectMiddleware: | ||
| """Resolve legacy documentation URLs before rendering the frontend.""" | ||
|
|
||
| def __init__( | ||
| self, | ||
| app: ASGIApp, | ||
| redirects: Sequence[tuple[str, str]], | ||
| frontend_path: str, | ||
| ) -> None: | ||
| """Build a lookup of public legacy URLs and their canonical destinations. | ||
|
|
||
| Args: | ||
| app: The wrapped application. | ||
| redirects: App-relative source and destination routes. | ||
| frontend_path: The public mount prefix. | ||
| """ | ||
| self.app = app | ||
| prefix = frontend_path.rstrip("/") | ||
| self.redirects = { | ||
| prefix + source.rstrip("/"): prefix + target for source, target in redirects | ||
| } | ||
|
|
||
| async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: | ||
| """Redirect known GET/HEAD routes and pass other requests through. | ||
|
|
||
| Args: | ||
| scope: The ASGI connection scope. | ||
| receive: The ASGI receive callable. | ||
| send: The ASGI send callable. | ||
| """ | ||
| if scope["type"] == "http" and scope["method"] in {"GET", "HEAD"}: | ||
| target = self.redirects.get(scope["path"].rstrip("/")) | ||
| if target is not None: | ||
| if query := scope.get("query_string", b""): | ||
| target += "?" + query.decode("latin-1") | ||
| await RedirectResponse(target, status_code=301)(scope, receive, send) | ||
| return | ||
| await self.app(scope, receive, send) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.