Skip to content

ENG-10639: Update Reflex UI twmerge utility to use clsx and tailwind-… - #6814

Open
carlosabadia wants to merge 1 commit into
mainfrom
carlos/update-twmerge
Open

ENG-10639: Update Reflex UI twmerge utility to use clsx and tailwind-…#6814
carlosabadia wants to merge 1 commit into
mainfrom
carlos/update-twmerge

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

Has better for support for tailwindv4

@carlosabadia
carlosabadia requested review from a team and Alek99 as code owners July 27, 2026 14:06
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jul 27, 2026
@linear-code

linear-code Bot commented Jul 27, 2026

Copy link
Copy Markdown

ENG-10639

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps

greptile-apps Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the internal Tailwind class-merging utility and its dependency coverage.

  • Replaces clsx-for-tailwind with a composed clsx and tailwind-merge implementation.
  • Pins clsx 2.1.1 and tailwind-merge 3.6.0 in the documentation app lockfiles.
  • Adds a unit test covering generated expressions and import metadata.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failure identified.

The replacement preserves supported class-input handling, emits valid default and named imports, and propagates pinned dependencies through the existing frontend package installation flow.

Important Files Changed

Filename Overview
packages/reflex-components-internal/src/reflex_components_internal/utils/twmerge.py Correctly composes the default clsx export with the named twMerge export while preserving Var import metadata.
tests/units/reflex_components_internal/utils/test_twmerge.py Verifies class-input serialization and both required versioned frontend imports.
docs/app/reflex.lock/package.json Adds the direct dependencies required by the updated utility while retaining a package still used elsewhere.
docs/app/reflex.lock/bun.lock Consistently resolves the newly pinned direct dependencies and preserves existing transitive versions.

Reviews (1): Last reviewed commit: "ENG-10639: Update Reflex UI twmerge util..." | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jul 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing carlos/update-twmerge (b3e0bbc) with main (416eb34)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant