useful-not-found-page - Refactor#9812
Draft
fregante wants to merge 6 commits into
Draft
Conversation
fregante
commented
Jul 12, 2026
| () => parseCurrentUrl().length > 1, | ||
| ], | ||
| awaitDomReady: true, // Small page | ||
| init: onetime(showMissingPartOnce), |
Member
Author
There was a problem hiding this comment.
Long overdue updates: the breadcrumbs now only appear on repo files. There are very few instances in which a breadcrumb makes sense outside of this. The only one being :real-user/:404-repo, which needs a single link and could be done separately.
| } | ||
|
|
||
| async function initRepoFile(signal: AbortSignal): Promise<void> { | ||
| observe('#repos-header-breadcrumb-wide-heading + ol a', crossIfNonExistent, {signal}); |
Member
Author
There was a problem hiding this comment.
Lost in the mess of this huge feature was this helper that crossed-through GitHub's own breadcrumbs. Sadly these only appear on /tree/ pages, so we still need our own breadcrumbs on /blob/ pages.
Selector updated, our breadcrumb hidden on /tree/ pages.
|
|
||
| /* | ||
|
|
||
| Test URLs: |
Member
Author
There was a problem hiding this comment.
Wasn't me. Fails without RG too
https://github.com/refined-github/refined-github/tree/nope/source/lol/highest-rated-comment
useful-not-found-page - Componentizeuseful-not-found-page - Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Test URLs
f3b5e71(#9773)Screenshot