Skip to content

useful-not-found-page - Refactor#9812

Draft
fregante wants to merge 6 commits into
mainfrom
svelte-404
Draft

useful-not-found-page - Refactor#9812
fregante wants to merge 6 commits into
mainfrom
svelte-404

Conversation

@fregante

@fregante fregante commented Jul 11, 2026

Copy link
Copy Markdown
Member

@fregante fregante left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status:

Image

Arguably we don't need this breadcrumb, we could alter the existing path in place, linkifying the sub-parts.

We also have additional useful links outside the breadcrumbs:

Screenshot 4 Screenshot 5

() => parseCurrentUrl().length > 1,
],
awaitDomReady: true, // Small page
init: onetime(showMissingPartOnce),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long overdue updates: the breadcrumbs now only appear on repo files. There are very few instances in which a breadcrumb makes sense outside of this. The only one being :real-user/:404-repo, which needs a single link and could be done separately.

}

async function initRepoFile(signal: AbortSignal): Promise<void> {
observe('#repos-header-breadcrumb-wide-heading + ol a', crossIfNonExistent, {signal});

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost in the mess of this huge feature was this helper that crossed-through GitHub's own breadcrumbs. Sadly these only appear on /tree/ pages, so we still need our own breadcrumbs on /blob/ pages.

Selector updated, our breadcrumb hidden on /tree/ pages.


/*

Test URLs:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fregante fregante changed the title useful-not-found-page - Componentize useful-not-found-page - Refactor Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant