Skip to content

ci: cap validate-build at 15 minutes - #429

Open
JakeSCahill wants to merge 1 commit into
mainfrom
jake/validate-build-timeout
Open

ci: cap validate-build at 15 minutes#429
JakeSCahill wants to merge 1 commit into
mainfrom
jake/validate-build-timeout

Conversation

@JakeSCahill

Copy link
Copy Markdown
Contributor

Summary

Adds timeout-minutes: 15 to the build job in validate-build.yml. Successful runs finish in 1-2 minutes; without a cap, a wedged npm ci occupies a runner for GitHub's full 6-hour default before being cancelled.

This is exactly what hit #395: the branch had been idle 9 days, so the node_modules cache had been evicted, the resulting real npm ci stalled on the registry with no output, and the job hung for 6 hours before GitHub killed it - reported as an opaque check failure on a commit that only touched a header partial. (A re-run passed with no changes.)

15 minutes is ~7x headroom over the slowest observed successful run, and the workflow already uses timeout-minutes on its Go lint step.

Test plan

  • validate-build passes on this PR (the change is the workflow itself)

🤖 Generated with Claude Code

Successful runs finish in 1-2 minutes. Without a job timeout, a wedged
npm ci - seen on PR #395 when the node_modules cache had expired after 9
idle days and the registry connection stalled - occupies a runner for
GitHub's full 6-hour default before being cancelled, and reports as an
opaque failure on the PR.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@netlify

netlify Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploy Preview for docs-ui ready!

Name Link
🔨 Latest commit 8955b03
🔍 Latest deploy log https://app.netlify.com/projects/docs-ui/deploys/6a96edbbf3e95200082ecf70
😎 Deploy Preview https://deploy-preview-429--docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🟢 up 2 from production)
Accessibility: 89 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 89 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 16116d16-ff5c-495a-8deb-629d1cf68bbf

📥 Commits

Reviewing files that changed from the base of the PR and between 663019b and 8955b03.

📒 Files selected for processing (1)
  • .github/workflows/validate-build.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The validate-build workflow now sets a 15-minute timeout on its build job. An explanatory comment states that normal runs take 1–2 minutes and that the limit prevents a stalled npm ci from using GitHub’s default six-hour runner limit.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8955b

This change caps the build validation job at 15 minutes to prevent indefinitely hung runs; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: limiting the validate-build workflow to 15 minutes.
Description check ✅ Passed The description accurately explains the timeout change, its purpose, observed runtime context, and test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jake/validate-build-timeout

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant