Skip to content

Fixing a key collision in RPCN pipeline list#2563

Open
SpicyPete wants to merge 1 commit into
masterfrom
rpcn/listing-page-minor
Open

Fixing a key collision in RPCN pipeline list#2563
SpicyPete wants to merge 1 commit into
masterfrom
rpcn/listing-page-minor

Conversation

@SpicyPete

Copy link
Copy Markdown
Contributor

Fix duplicate React keys in the RPCN pipeline list

The Input/Processors/Output columns keyed connector badges by component name, but parseConfigComponents intentionally preserves duplicates (e.g. a broker input with two redpanda children yields ['redpanda', 'redpanda']), so pipelines reusing a component triggered React's duplicate-key warning (Encountered two children with the same key, '.$redpanda') on every render.

Changes

  • Add a toKeyedNames helper that suffixes each name with its occurrence count (redpanda-0, redpanda-1) and use it for the badge cells and their "+N more" overflow lists. Occurrence counts are used instead of array indexes to keep keys stable and satisfy Biome's noArrayIndexKey.
  • Suppress the pre-existing noArrayIndexKey warning on the static skeleton rows, leaving the file lint-clean.

No behavior change — duplicate badges still render; they just get unique keys.

@SpicyPete SpicyPete self-assigned this Jul 17, 2026
@SpicyPete SpicyPete added the bug Something isn't working label Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Clean — no registry drift, off-token colours, or ad-hoc classes

App: frontend · Scope: diff vs origin/master · Files: 1

Count
⚠️ Outdated registry components 0
🛠 Locally-modified components 0
❓ Unknown to registry 0
🎨 Off-token palette colours 0
🔢 Ad-hoc utility classes 0

Generated by lookout audit-changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant