DOC-2021: Point cross-region PrivateLink readers to Terraform support#637
DOC-2021: Point cross-region PrivateLink readers to Terraform support#637Feediver1 wants to merge 3 commits into
Conversation
The supported_regions Terraform field has existed since provider v1.8.0 but the platform page only named the Cloud UI and Cloud API as configuration methods. Add the cross-link and note the multi-AZ requirement on the Terraform example. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe documentation updates clarify cross-region AWS PrivateLink configuration for Terraform-managed clusters. The dedicated cluster example notes that Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
After merging main, the Configure cross-region PrivateLink section carried two Terraform pointers: #635's intro sentence (targeting the provider page's purpose-built cross-region section) and this PR's paragraph (targeting the generic Dedicated-cluster example). Keep #635's. Also for the record: supported_regions shipped in provider v1.7.0, not v1.8.0 as this PR's original commit message said (verified in #635 by SME review against the tag). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Feediver1
left a comment
There was a problem hiding this comment.
PR Review: DOC-2021: multi-AZ note on the Terraform cross-region example (#637)
Files reviewed: 1 .adoc file (+1/−1 after the post-#635 trim)
Overall assessment: Now a clean, single-purpose change; the earlier overlap with #635 is fully resolved.
Review history on this PR
- Original scope overlap (resolved in fb836fd): this PR predated #635's merge; its aws-privatelink paragraph became a redundant second Terraform pointer in the same section (aimed at the generic Dedicated-cluster anchor while #635's intro sentence points at the purpose-built Configure cross-region AWS PrivateLink section). Removed; the PR's net diff is now
terraform-provider.adoconly. - Version correction (recorded): the original commit message's "since v1.8.0" contradicted #635's SME-verified v1.7.0 (tag-checked in
schema_resource.go, released 2026-02-26). Corrected in the follow-up commit message, the PR body, and on DOC-2021.
What remains — and it's good
The multi-AZ note on the Dedicated example's supported_regions comment fills a real gap: the requirement is documented in the Requirements lists but was absent at the example a copy-pasting user actually touches — the exact spot where a single-AZ user would hit a confusing failure. Verified rendering in the deploy preview.
Verdict
Ready to merge; resolves DOC-2021 jointly with #635.
🤖 Generated with Claude Code
Description
Closes the remaining gap in DOC-2021 (ENG-1063, cross-region AWS PrivateLink via Terraform).
Scope note (2026-07-20): most of this ticket's gap was closed by #635, which merged today with a dedicated Configure cross-region AWS PrivateLink section on the provider page, a pointer from the platform page, and the What's New mention — all stating the correct provider version (v1.7.0+, SME-verified; this PR's original commit message said v1.8.0, which was wrong). This PR's aws-privatelink paragraph was superseded by #635's pointer and has been removed.
What remains in this PR:
manage/terraform-provider.adoc: the full Dedicated-cluster example'ssupported_regionscomment now notes the multi-AZ requirement (documented in the Requirements lists, but absent at this example site — prevents a confusing failure for single-AZ clusters).Resolves DOC-2021 (jointly with the substantive docs from #635).
Page previews
supported_regionscomment is verified rendering in this preview)Checks
🤖 Generated with Claude Code