Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Pull request overview
This PR updates Redis product naming throughout the codebase: "RediSearch" is renamed to "Redis Search", "Redis Stack" references are removed, and Docker images are updated from redis/redis-stack-server to redis:8.4. It also renames helper functions like skip_if_no_redisearch → skip_if_no_redis_search for consistency.
Changes:
- Renamed all occurrences of "RediSearch" to "Redis Search" and removed "Redis Stack" references in code comments, docstrings, error messages, and documentation.
- Updated Docker images from
redis/redis-stack-server:latestandredis:8.0toredis:8.4across docker-compose files, CI workflows, Makefile, and test configuration. - Renamed test helper functions (
has_redisearch_module→has_redis_search_module,skip_if_no_redisearch→skip_if_no_redis_search, and their async variants) and updated all call sites.
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Renamed helper functions and updated default Redis image |
| tests/docker-compose.yml | Updated default Redis image to redis:8.4 |
| tests/cluster-compose.yml | Updated all cluster node images to redis:8.4 |
| .github/workflows/test.yml | Updated CI matrix and notebook test images |
| Makefile | Updated redis-start target image |
| docs/user_guide/installation.md | Updated installation docs with new naming and image |
| docs/index.md | Updated Docker run command |
| docs/concepts/field-attributes.md | Updated naming in docs |
| docs/api/schema.rst | Updated naming in API docs |
| docs/user_guide/cli.ipynb | Updated naming in notebook |
| docs/user_guide/09_svs_vamana.ipynb | Updated naming in notebook |
| CONTRIBUTING.md | Updated naming and removed RedisInsight reference |
| CLAUDE.md | Updated naming in dev guide |
| redisvl/schema/fields.py | Updated comments |
| redisvl/redis/constants.py | Updated comments |
| redisvl/redis/connection.py | Updated comments |
| redisvl/query/query.py | Updated docstrings |
| redisvl/utils/token_escaper.py | Updated comment |
| redisvl/exceptions.py | Updated error message |
| tests/integration/* | Updated all skip_if_no_redisearch calls to skip_if_no_redis_search and naming in comments |
| tests/unit/test_filter.py | Updated comment |
| tests/unit/test_field_modifier_ordering.py | Updated docstring |
| pyproject.toml | Added unrelated mypy override for mistralai |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Addresses #529 thanks @dwdougherty |
tylerhutcherson
added
the
auto:documentation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| services: | ||
| redis: | ||
| image: "${REDIS_IMAGE:-redis/redis-stack-server:latest}" | ||
| image: "${REDIS_IMAGE:-redis:8.4}" |
There was a problem hiding this comment.
REDIS_ARGS env var silently ignored by official Redis image
Medium Severity
The REDIS_ARGS environment variable (--save '' --appendonly no) was a feature of the redis/redis-stack-server image's custom entrypoint. The official redis:8.4 image does not process this env var — it only accepts arguments via the container command. This means the persistence-disabling configuration is now silently ignored, and test containers will run with Redis's default RDB snapshot settings, potentially causing slower tests and unwanted disk I/O during CI runs.
| python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| redis-py-version: ["5.x", "6.x", "7.x"] | ||
| redis-image: ["redis/redis-stack-server:latest", "redis:latest"] | ||
| redis-image: ["redis:8.4", "redis:latest"] |
There was a problem hiding this comment.
Is there a reason we specifically need to test 8.4?
vishal-bala
added
auto:tests
Redis Query Engine and RediSearch --> Redis Search
Removed the use of Redis Stack completely
Note
Low Risk
Mostly documentation/CI/tooling updates plus test helper renames; functional surface area changes are limited to clearer SVS-VAMANA error messaging and pinned Docker images, with low risk of runtime regressions.
Overview
Updates product terminology across docs, comments, and test helpers from RediSearch/Query Engine to Redis Search, including renaming skip/check utilities in
tests/conftest.pyand adjusting related integration tests.Removes Redis Stack usage in local/dev and CI flows by pinning Docker images to
redis:8.4(Makefileredis-start, GitHub Actions matrix/notebook runner, and test docker-compose/cluster-compose), and adds amypyoverride to skip importingmistralaistubs.Written by Cursor Bugbot for commit 9e212b6. This will update automatically on new commits. Configure here.