feat(sentinel): add scan iterator#3278
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scanIterator()toRedisSentinelscanIterator()to acquiredRedisSentinelClientleasesCloses #2999
Validation
npm run lint:changednpm run buildSentinel integration tests were not run locally because Docker is not installed in this environment.
Note
Medium Risk
Adds a new async-iterator API around
SCANon Sentinel and leased clients, touching pooled lease usage and iteration control flow; risk is mainly around potential pool starvation/performance/regression in edge cursor/type cases.Overview
Adds
scanIterator()to both theRedisSentinelfacade and acquiredRedisSentinelClientleases, providing an async generator that pages throughSCANresults (with optional startingcursor) and yields key batches until completion.Includes new Sentinel integration tests covering password/no-password setups, iteration via both the facade and leased clients, and a regression case ensuring iteration doesn’t deadlock when the master pool is size 1 (by releasing the per-page lease before yielding).
Reviewed by Cursor Bugbot for commit a4c51cb. Bugbot is set up for automated code reviews on this repo. Configure here.