feat(sentinel): emit lifecycle events#3276
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3012.
createSentinel()exposesisOpenandisReady, but it did not emit the lifecycle events that standalone clients expose. This addsconnectandreadyemissions after Sentinel finishes connecting, and emitsendafter closing or destroying an instance that was open.The change is additive and keeps the event ordering aligned with the state a Sentinel consumer can observe.
Validation
.\node_modules\.bin\tsc.cmd --build packages/client --force --verbosenpm run lint:changedgit diff --checkNote: the focused Sentinel mocha test could not run locally because Docker is not installed in this Windows environment (
spawn docker ENOENT).Note
Low Risk
Low risk additive behavior change: emits
connect/readyafter successfulRedisSentinel.connect()and emitsendonclose()/destroy()when previously open; could affect consumers that assume no events or different ordering.Overview
RedisSentinelnow emits lifecycle events consistent with standalone clients:connectandreadyare emitted afterconnect()completes, andendis emitted afterclose()ordestroy()when the instance was previously open.Adds a focused sentinel test (
lifecycle-events.spec.ts) asserting theconnect→ready→endevent sequence and thatendis observable viaonce()after shutdown.Reviewed by Cursor Bugbot for commit ffdc7b5. Bugbot is set up for automated code reviews on this repo. Configure here.