fix: embed sources in emitted sourcemaps#3274
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3147.
This updates the shared TypeScript build configuration to emit
sourcesContentin generated source maps. The current generated maps include paths like../index.ts, but the published package does not include those source files, so debugger tooling cannot resolve the original TypeScript sources from the installed package alone.Validation
.\node_modules\.bin\tsc.cmd --build packages/client --force --verbosepackages/client/dist/index.js.mapand confirmedsourcesContentis presentnpm run buildnpm run lint:changedgit diff --checkNote
Low Risk
Low risk configuration change that only affects TypeScript build outputs by embedding
sourcesContentin generated source maps.Overview
Enables debuggers to resolve original TypeScript sources from installed packages by setting
inlineSources: trueintsconfig.base.json, causing generated.mapfiles to includesourcesContent.Reviewed by Cursor Bugbot for commit 098cad6. Bugbot is set up for automated code reviews on this repo. Configure here.