use mapped address when sentinel failover moved pubsub connections#3190
Open
elimelt wants to merge 1 commit intoredis:masterfrom
Open
use mapped address when sentinel failover moved pubsub connections#3190elimelt wants to merge 1 commit intoredis:masterfrom
elimelt wants to merge 1 commit intoredis:masterfrom
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Collaborator
|
@elimelt thanks for the PR, i will try to take a look soon, but im guessing - next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3192
Fix small bug in sentinel's new
nodeAddressMapoption - namely - when sentinel failovers cause pub-sub connections to migrate to a new master, the address mapping should be applied.This is 100% fixed by the patch (I patched with pnpm and got my client working), but I found it kind of difficult to write a good test that doesn't completely duplicate an existing test (e.g.
pubsub - channel - with master change)I'm also debating whether we want
getMasterNodeand similar to return the mapped address or notChecklist
npm testpass with this change (including linting)?Note
Medium Risk
Changes Sentinel failover reconfiguration logic for pub/sub connections; if the mapping is incorrect or incomplete it could cause pub/sub to reconnect to the wrong/unreachable node during master switches.
Overview
When Sentinel detects a new master, the pub/sub proxy now switches to the mapped node address (via
getMappedNode(..., nodeAddressMap)) instead of using the raw Sentinel-reported host/port.This fixes cases where
nodeAddressMapis required (e.g., NAT/container networking) and failover previously moved pub/sub connections to an unmapped address.Written by Cursor Bugbot for commit b7a34da. This will update automatically on new commits. Configure here.