Conversation
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
One broken link; otherwise, LGTM.
cmilesb
left a comment
cmilesb
left a comment
There was a problem hiding this comment.
This is a partial review. I'd be happy to make some of these changes myself in a separate PR.
layouts/home.html
Outdated
|
|
||
| <!-- Redis Cloud --> | ||
| <div class="flex flex-col bg-redis-ink-900 border-2 border-redis-red-500 rounded-md overflow-hidden"> | ||
| <div class="px-4 py-2 border-b border-redis-pen-400"> |
There was a problem hiding this comment.
I think it would be useful to have these be buttons as well leading to the home page of each section. In my testing changing "div" to "a" seems to work, and adding the style to transition colors. Would be happy to make the changes myself.
layouts/home.html
Outdated
| </div> | ||
|
|
||
| <!-- Redis Cloud --> | ||
| <div class="flex flex-col bg-redis-ink-900 border-2 border-redis-red-500 rounded-md overflow-hidden"> |
There was a problem hiding this comment.
I don't mind the border and red text here too much, but I really don't like the fact that the background is the same color as the page background.
I'd recommend changing this color to match the software color, but then the Red color doesn't contrast well enough for the text. (Actually, as it stands, the text/background could be contrasted a little more - it seems to pass most of the tests but not all of them.) Happy to test colors myself here to see what works best. Maybe also a "Recommended" badge to make it stand out?
There was a problem hiding this comment.
Thank you so much Cameron! Yes, any changes you want to work on would be great.
|
The main thing I notice is that the full-width layout and the narrow mobile layout work OK, but in the "intermediate" width layout, the nav buttons at the left display on top of the content. However, this also happens with the current layout, so maybe we've decided it's not an issue? Anyway, I think the new layout looks pretty good and it crams more information into a smaller space. |
Co-authored-by: Cameron Bates <102550101+cmilesb@users.noreply.github.com>
Co-authored-by: Cameron Bates <102550101+cmilesb@users.noreply.github.com>
Co-authored-by: Cameron Bates <102550101+cmilesb@users.noreply.github.com>
Doc home update edits
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
- Move AI chatbot search box to align with 'Redis for AI and search' heading - Center H1 'Welcome to Redis Docs' heading - Update 'Redis Cloud' link to 'Redis Flex' with new target URL - Remove AI chatbot search from 'Explore the documentation' section - Adjust spacing and alignment throughout
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
The thing with the nav bar appearing over the content boxes still seems to be there but otherwise I'd say it's looking really good :-) |
| </a> | ||
| </div> | ||
| <p class="text-sm text-gray-300 text-center"> | ||
| Search the <a href='{{ relURL "commands" }}' class="text-redis-yellow-500 hover:underline">complete command reference</a> and the <a href='{{ relURL "integrate" }}' class="text-redis-yellow-500 hover:underline">integrated libraries and tools</a> |
There was a problem hiding this comment.
Inconsistent link styles break staging navigation
Medium Severity
The new content sections mix two different link styles: {{ relURL "commands" }} and {{ relURL "integrate" }} on line 62 vs ./develop/, ./operate/rc/, etc. everywhere else. On staging (served under a subpath like /docs/staging/doc-home-update/), relURL resolves from the site root while ./ resolves relative to the current page. This means the "complete command reference" and "integrated libraries and tools" links navigate to a different path hierarchy than every other link on the page. The PR reviewer flagged this exact concern about ./ vs direct links for staging consistency.
Additional Locations (1)
Added a link to the Redis Knowledge Base with a brief description.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Updated the support article description and removed the community link.
4 participants
Here is a new draft of the docs home page in response to feedback that the current one is overwhelming and to help make the main options more clear at the top of the page. Any and all feedback welcomed and no rush on this one https://redis.io/docs/staging/doc-home-update/
Note
Medium Risk
Large
layouts/home.htmlrestructure changes the primary navigation/CTA flow and many internal links, so regressions are most likely around layout and broken/incorrect destinations. No backend or security-sensitive logic is touched.Overview
Refreshes
layouts/home.htmlto make the top of the page more directive: a smaller centered welcome header with two primary CTA buttons (develop open source vs run in production) and a short prompt pointing tocommands/integrate.Replaces the prior multi-card “Get Started” and “Deploy & Operate” partial-driven content with new, more opinionated sections: “Redis for AI and search” (use-case link grid +
/chatprompt), product continuum cards (Open Source/Software/Cloud), “Choose your next step” intent cards, and an “Explore the documentation” quick-links grid. Also appliesfont-monomore broadly and tweaks the AI search placeholder copy.Written by Cursor Bugbot for commit 1002e76. This will update automatically on new commits. Configure here.