Skip to content

Fix #4167: use java.projects context for explorer actions#4450

Open
MeherSru wants to merge 2 commits into
redhat-developer:mainfrom
MeherSru:fix-4167-array-context-keys
Open

Fix #4167: use java.projects context for explorer actions#4450
MeherSru wants to merge 2 commits into
redhat-developer:mainfrom
MeherSru:fix-4167-array-context-keys

Conversation

@MeherSru

Copy link
Copy Markdown
Contributor

No description provided.

@MeherSru

Copy link
Copy Markdown
Contributor Author

This change introduces the java.projects array context and uses it to make the Add/Remove Source Path Explorer actions more precise. These actions are now only shown for Java project folders instead of every folder in the Explorer.

@MeherSru MeherSru marked this pull request as ready for review June 30, 2026 09:22

@wenytang-ms wenytang-ms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling #4167! The array-context-key approach is the right tool here, but I think it's wired to the wrong set for these two actions. Left a few inline notes.
please also consider adding PR's description.

Comment thread package.json Outdated
Comment thread src/standardLanguageClient.ts Outdated
Comment thread src/standardLanguageClient.ts Outdated
@MeherSru

MeherSru commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@wenytang-ms Thanks for the detailed feedback! I've updated the PR to address the comments. I reverted the Explorer menu changes, moved the java.projects update out of the javaLSReady path, and added a helper to refresh the context when projects are imported or deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants